-
Notifications
You must be signed in to change notification settings - Fork 188
gmm for regression added #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
moe18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one small issue with the learn section
| ## **1. What’s a Gaussian Process?** | ||
| A **Gaussian Process** defines a distribution over functions \( f(\cdot) \). For any finite set of inputs \(X=\{x_i\}_{i=1}^n\), the function values \(f(X)\) follow a multivariate normal: | ||
|
|
||
| \[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the learn section should use $$ and $ for formulas, you could check out the other learn sections to see how it is done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have used $ for inline mathematical expression and similarly $$ for multi line expression, check it out and let me know is there anything else to resolve
moe18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, just some small notes
| gp.fit(X_train, y_train) | ||
| X_test = np.array([[3.0]]) | ||
| mu = gp.predict(X_test) | ||
| print(f"{mu[0]:.4f}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove print statements
| } | ||
| # Re-fit with optimal hyperparameters | ||
| self.fit(self.X_train, self.y_train) | ||
| print("Optimized Hyperparameters:", self.kernel_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove print
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "id": "175", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make the ID 186
| { | ||
| "id": "175", | ||
| "title": "Gaussian Process for Regression", | ||
| "difficulty": "medium", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it hard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made all the above changes , change id to 186 and folder name also changed accordingly and removed all the print statement.
…with 186_ and also removed all the print statement
I have run this command , it is python utils/build_bundle.py && python utils/validate_questions.py running successfully. I have written code for Gaussian Mixture Model for regression.